Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ACLs e2e test #76

Merged
merged 5 commits into from
Sep 17, 2024
Merged

feat: ACLs e2e test #76

merged 5 commits into from
Sep 17, 2024

Conversation

goran-ethernal
Copy link
Collaborator

Description

This PR adds e2e bats tests for Access List feature.

Fixes # (issue)
JIRA ticket

@goran-ethernal goran-ethernal self-assigned this Sep 16, 2024
@goran-ethernal goran-ethernal force-pushed the CDK-477-implement-acl-e2e-test branch 2 times, most recently from eee228c to 7515c88 Compare September 16, 2024 13:07
@goran-ethernal goran-ethernal marked this pull request as ready for review September 16, 2024 13:28
vcastellm

This comment was marked as outdated.

Sign in to view

vcastellm
vcastellm requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider getting rid of this env dependent hardcoded path?

/home/erigon/data/dynamic-kurtosis-sequencer/txpool/acls

@goran-ethernal
Copy link
Collaborator Author

Consider getting rid of this env dependent hardcoded path?

/home/erigon/data/dynamic-kurtosis-sequencer/txpool/acls

Unfortunately, this is the path of the db for txpool and acls in the cdk-erigon-sequencer docker container. I can make it configurable in the tests at best, but I don't know an easy or non "hacky" way to get this from the docker container.

@vcastellm
Copy link
Contributor

Consider getting rid of this env dependent hardcoded path?
/home/erigon/data/dynamic-kurtosis-sequencer/txpool/acls

Unfortunately, this is the path of the db for txpool and acls in the cdk-erigon-sequencer docker container. I can make it configurable in the tests at best, but I don't know an easy or non "hacky" way to get this from the docker container.

Sure, we just need to make it configurable, would that work?

Base automatically changed from poc_bats to develop September 16, 2024 14:42
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a couple of comments to consider.

test/access-list-e2e.bats Outdated Show resolved Hide resolved
test/access-list-e2e.bats Show resolved Hide resolved
@goran-ethernal
Copy link
Collaborator Author

Consider getting rid of this env dependent hardcoded path?
/home/erigon/data/dynamic-kurtosis-sequencer/txpool/acls

Unfortunately, this is the path of the db for txpool and acls in the cdk-erigon-sequencer docker container. I can make it configurable in the tests at best, but I don't know an easy or non "hacky" way to get this from the docker container.

Sure, we just need to make it configurable, would that work?

Done: 773670d

vcastellm
vcastellm requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kurtosis command should also be parameterizable to be able to run without Kurtosis in a local node, ex:

$wrapper="kurtosis service exec $enclave $sequencer"
or 
$wrapper="sh -c"

`$wrapper` "acl mode --datadir $data_dir --mode $mode"

@goran-ethernal
Copy link
Collaborator Author

Kurtosis command should also be parameterizable to be able to run without Kurtosis in a local node, ex:

$wrapper="kurtosis service exec $enclave $sequencer"
or 
$wrapper="sh -c"

`$wrapper` "acl mode --datadir $data_dir --mode $mode"

Fix: 460d42f

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@goran-ethernal goran-ethernal merged commit d2fd29a into develop Sep 17, 2024
9 checks passed
@goran-ethernal goran-ethernal deleted the CDK-477-implement-acl-e2e-test branch September 17, 2024 08:17
Stefan-Ethernal pushed a commit that referenced this pull request Sep 17, 2024
@goran-ethernal @Stefan-Ethernal
feat: ACLs e2e test (#76)
10eb3f1 
* feat: acl e2e test

* fix: setup private key

* fix: comments

* fix: comments

* fix: comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goran-ethernal @vcastellm @Stefan-Ethernal